Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation for End-to-End Test Suite #203

Merged
merged 12 commits into from
Aug 15, 2024

Conversation

nox1134
Copy link
Member

@nox1134 nox1134 commented Aug 11, 2024

This PR introduces documentation for the end-to-end test suite being developed as part of the GSoC project.
The documentation covers the following aspects:

  • Introduction
  • Setup
  • Configuring the Test Environment
  • Acceptance Tests Structure
  • Writing and Running Tests
  • Contributing
image

Signed-off-by: Priyanshi Gaur <[email protected]>
Signed-off-by: Priyanshi Gaur <[email protected]>
@RCheesley RCheesley self-requested a review August 12, 2024 10:24
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this excellent PR @nox1134 and for all your hard work on the Summer of Code project!

There are quite a few suggestions but they fall into these broad categories:

  1. Using active instead of passive when writing - I've fixed the ones that Vale has flagged
  2. I've made a commit to add Codeception and XPath to the allowed terms
  3. Using inline code syntax (double backtick) for file and folder names, and anything where we're referring to something like a command to be run.
  4. Not using Camel Case in headings - use sentence case (only the first letter is capitalised unless there's another grammatical reason why to capitalise others, in which case we use vale off)
  5. A few small changes to use more inclusive language

Hopefully should be fairly straightforward to implement but shout if you have any further issues with Vale in #t-education on Slack!

docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
@nox1134
Copy link
Member Author

nox1134 commented Aug 12, 2024

XPath wasn't added, so I have added XPath and also php to the allowed terms.

@RCheesley
Copy link
Member

and also php to the allowed terms.

php (lower case) should not be added. It should always be capitalised. Where was it that it was flagging this up? It might be a missed filename being surrounded by inline code syntax.

I added XPath but totally missed pushing the commit - sorry!

@nox1134
Copy link
Member Author

nox1134 commented Aug 14, 2024

php (lower case) should not be added. It should always be capitalised. Where was it that it was flagging this up? It might be a missed filename being surrounded by inline code syntax.

Yeah you are right! A filename not being surrounded by inline code syntax was causing that error.

@nox1134 nox1134 requested a review from RCheesley August 14, 2024 18:48
Signed-off-by: Priyanshi Gaur <[email protected]>
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny Vale fix then we're good to go! 🚀

docs/testing/e2e_test_suite.rst Outdated Show resolved Hide resolved
Signed-off-by: Priyanshi Gaur <[email protected]>
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@RCheesley RCheesley merged commit 8a62643 into mautic:5.x Aug 15, 2024
2 checks passed
@mautibot
Copy link
Collaborator

mautibot commented Sep 2, 2024

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/gsoc-2024-project-report-end-to-end-test-suite-for-mautic/33354/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants